codope commented on code in PR #11597:
URL: https://github.com/apache/hudi/pull/11597#discussion_r1694999684
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -211,7 +200,7 @@ public HoodieMetadataPayload(Option<GenericRecord>
recordOpt) {
key = record.get(KEY_FIELD_NAME).toString();
type = (int) record.get(SCHEMA_FIELD_NAME_TYPE);
- if (type == METADATA_TYPE_FILE_LIST || type ==
METADATA_TYPE_PARTITION_LIST) {
+ if (type == MetadataPartitionType.FILES.getRecordType() || type ==
MetadataPartitionType.FILES.getRecordType(RECORDKEY_PARTITION_LIST)) {
Review Comment:
Agree with the general idea. For this PR, I have refactored
`MetadataPartitionType` to only construct payload and combine payloads for
multiple partition types. Will followup with more refactoring in subsequent PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
