yihua commented on code in PR #11580:
URL: https://github.com/apache/hudi/pull/11580#discussion_r1696040125
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -113,6 +113,7 @@ protected Option<HoodieRollbackPlan> requestRollback(String
startRollbackTime) {
HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new
HoodieInstantInfo(instantToRollback.getTimestamp(),
instantToRollback.getAction()), rollbackRequests,
LATEST_ROLLBACK_PLAN_VERSION);
if (!skipTimelinePublish) {
+ table.validateForLatestTimestamp(rollbackInstant.getTimestamp());
Review Comment:
I think we should guarantee monotonically increasing instant time generation
on the timeline on storage as @danny0405 mentioned. Adding per-action handling
for the same guarantee is unmaintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
