wangxianghu commented on pull request #2033: URL: https://github.com/apache/hudi/pull/2033#issuecomment-679987475
> for such a helper struct like class, it makes sense to be inline right? can you please help me understand the reason behind this refactor. @vinothchandar thanks for the reply This is prepared for the multi-engine support abstraction. In the abstraction, MergerHelper can be abstract to an abstract class, its inner class UpdateHandler referenced HoodieMergeHandle, which is related to spark. so I think maybe we can make it an independent class, convenient to expand. Doing these little adjusts before rebase(or refactor) can reduce the review work of HUDI-1089, that`s my thought, WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
