lokeshj1703 commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2261806130
@danny0405 I see a revert in your patch -
```
public String getCompletionTime() {
- return completionTime != null ? completionTime : stateTransitionTime;
+ return completionTime;
}
```
Earlier implementation used `stateTransitionTime` for this function. The new
implementation renamed the function from `getStateTransitionTime` to
`getCompletionTime`. Are we sure that if completion time is null, the callers
of the API would be able to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
