danny0405 commented on code in PR #11730:
URL: https://github.com/apache/hudi/pull/11730#discussion_r1705064471


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -502,6 +502,8 @@ object HoodieFileIndex extends Logging {
     val isMetadataTableEnabled = getConfigValue(options, sqlConf, 
HoodieMetadataConfig.ENABLE.key, null)
     if (isMetadataTableEnabled != null) {
       properties.setProperty(HoodieMetadataConfig.ENABLE.key(), 
String.valueOf(isMetadataTableEnabled))
+    } else {
+      properties.setProperty(HoodieMetadataConfig.ENABLE.key(), 
String.valueOf(HoodieMetadataConfig.ENABLE.defaultValue()))

Review Comment:
   Did you test the case for reading a metadata-disabled table with this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to