danny0405 commented on code in PR #11748:
URL: https://github.com/apache/hudi/pull/11748#discussion_r1712447193
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -314,7 +314,7 @@ public static boolean partitionExists(String tablePath,
String partitionPath, or
* Generates the bucket ID using format {partition path}_{fileID}.
*/
public static String generateBucketKey(String partitionPath, String fileId) {
- return String.format("%s_%s", partitionPath, fileId);
+ return partitionPath + "_" + fileId;
Review Comment:
yeah, I found this doc:
https://dip-mazumder.medium.com/stringbuilder-vs-string-in-java-a-guide-for-optimal-memory-usage-4a284d8243ea#:~:text=In%20conclusion%2C%20when%20it%20comes,can%20lead%20to%20performance%20inefficiencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
