TheR1sing3un commented on code in PR #11755:
URL: https://github.com/apache/hudi/pull/11755#discussion_r1713340004


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/RunCompactionActionExecutor.java:
##########
@@ -125,6 +125,7 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> 
execute() {
       compactionMetadata.setWriteStatuses(statuses);
       compactionMetadata.setCommitted(false);
       compactionMetadata.setCommitMetadata(Option.of(metadata));
+      compactionMetadata.setWriteStats(updateStatusMap);

Review Comment:
   > Does line 116 already set up the write stat?
   
   Yes, same stats value, but line 166 set up it in HoodieCommitMetadata but 
not in HoodieWriteMetadata. I think we should also set it in 
HoodieWriteMetadata.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to