xicm commented on code in PR #11757:
URL: https://github.com/apache/hudi/pull/11757#discussion_r1713443105
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -415,9 +415,7 @@ public static DataStreamSink<CompactionCommitEvent>
compact(Configuration conf,
new CompactionPlanOperator(conf))
.setParallelism(1) // plan generate must be singleton
.setMaxParallelism(1)
- // make the distribution strategy deterministic to avoid concurrent
modifications
- // on the same bucket files
- .keyBy(plan -> plan.getOperation().getFileGroupId().getFileId())
+ .rebalance()
Review Comment:
One operator one file group, rebalance is ok.
This is what we do in HoodieFlinkCompactor
https://github.com/apache/hudi/blob/b7e11b1d018e07aa85bf7de49c05bc2ccb71262d/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/HoodieFlinkCompactor.java#L289-L303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
