jonvex commented on code in PR #11649:
URL: https://github.com/apache/hudi/pull/11649#discussion_r1714334146
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileGroupReaderBasedRecordReader.java:
##########
@@ -101,8 +102,7 @@ org.apache.hadoop.mapred.RecordReader<NullWritable,
ArrayWritable> getRecordRead
public HoodieFileGroupReaderBasedRecordReader(HiveReaderCreator
readerCreator,
final InputSplit split,
- final JobConf jobConf,
- final Reporter reporter)
throws IOException {
Review Comment:
reporting progress. I changed it so that the arg gets passed directly when
creating the readerCreator. It was only being used by the reader creator, so
this simplifies the code by not needing to pass an extra variable around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
