yihua commented on code in PR #11692:
URL: https://github.com/apache/hudi/pull/11692#discussion_r1717586624
##########
hudi-spark-datasource/hudi-spark3-common/src/main/java/org/apache/hudi/spark3/internal/ReflectUtil.java:
##########
@@ -29,17 +27,10 @@ public class ReflectUtil {
public static DateFormatter getDateFormatter(ZoneId zoneId) {
Review Comment:
We should have a follow-up PR to clean up any logic that is no long needed
for Spark 3.3 and above.
##########
.github/workflows/release_candidate_validation.yml:
##########
@@ -25,39 +25,23 @@ jobs:
- scalaProfile: 'scala-2.13'
flinkProfile: 'flink1.18'
sparkProfile: 'spark3.5'
- sparkRuntime: 'spark3.5.0'
+ sparkRuntime: 'spark3.5.1'
- scalaProfile: 'scala-2.12'
flinkProfile: 'flink1.18'
sparkProfile: 'spark3'
sparkRuntime: 'spark3.5.0'
- - scalaProfile: 'scala-2.12'
- flinkProfile: 'flink1.18'
- sparkProfile: 'spark3.5'
- sparkRuntime: 'spark3.5.0'
- - scalaProfile: 'scala-2.12'
- flinkProfile: 'flink1.18'
- sparkProfile: 'spark3.4'
- sparkRuntime: 'spark3.4.0'
- scalaProfile: 'scala-2.12'
flinkProfile: 'flink1.17'
- sparkProfile: 'spark3.3'
- sparkRuntime: 'spark3.3.2'
+ sparkProfile: 'spark3.5'
+ sparkRuntime: 'spark3.5.1'
- scalaProfile: 'scala-2.12'
flinkProfile: 'flink1.16'
- sparkProfile: 'spark3.3'
- sparkRuntime: 'spark3.3.1'
+ sparkProfile: 'spark3.4'
+ sparkRuntime: 'spark3.4.3'
- scalaProfile: 'scala-2.12'
flinkProfile: 'flink1.15'
- sparkProfile: 'spark3.2'
- sparkRuntime: 'spark3.2.3'
- - scalaProfile: 'scala-2.12'
- flinkProfile: 'flink1.14'
- sparkProfile: 'spark3.1'
- sparkRuntime: 'spark3.1.3'
- - scalaProfile: 'scala-2.12'
- flinkProfile: 'flink1.14'
- sparkProfile: 'spark3.0'
- sparkRuntime: 'spark3.0.2'
+ sparkProfile: 'spark3.3'
+ sparkRuntime: 'spark3.3.4'
Review Comment:
We also need
```
- scalaProfile: 'scala-2.12'
flinkProfile: 'flink1.14'
sparkProfile: 'spark3.3'
sparkRuntime: 'spark3.3.1'
```
In the future, we can directly delete Spark 2 profiles.
##########
.github/workflows/release_candidate_validation.yml:
##########
@@ -25,39 +25,23 @@ jobs:
- scalaProfile: 'scala-2.13'
flinkProfile: 'flink1.18'
sparkProfile: 'spark3.5'
- sparkRuntime: 'spark3.5.0'
+ sparkRuntime: 'spark3.5.1'
- scalaProfile: 'scala-2.12'
Review Comment:
This one can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
