danny0405 commented on code in PR #11777:
URL: https://github.com/apache/hudi/pull/11777#discussion_r1718173950
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -192,7 +192,8 @@ trait ProvidesHoodieConfig extends Logging {
// NOTE: Here we fallback to "" to make sure that null value is not
overridden with
// default value ("ts")
// TODO(HUDI-3456) clean up
- val preCombineField = combinedOpts.getOrElse(PRECOMBINE_FIELD.key, "")
+ val preCombineField =
combinedOpts.getOrElse(HoodieTableConfig.PRECOMBINE_FIELD.key,
+ combinedOpts.getOrElse(PRECOMBINE_FIELD.key, ""))
Review Comment:
I guess we need to finish HUDI-3456 then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
