prashantwason commented on a change in pull request #1804:
URL: https://github.com/apache/hudi/pull/1804#discussion_r477552841
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -81,6 +87,7 @@ public Builder fromProperties(Properties props) {
public Builder limitFileSize(long maxFileSize) {
props.setProperty(PARQUET_FILE_MAX_BYTES, String.valueOf(maxFileSize));
+ props.setProperty(HFILE_FILE_MAX_BYTES, String.valueOf(maxFileSize));
Review comment:
@vinothchandar I see that you split this function into file specific
functions. That doable but with more base file formats added, it may be
cumbersome and verbose to keep adding the .limitXXXFileSize for specific
formats.
I am ok either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
