jonvex commented on code in PR #11770: URL: https://github.com/apache/hudi/pull/11770#discussion_r1722042049
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala: ########## @@ -75,6 +75,9 @@ abstract class HoodieBaseHadoopFsRelationFactory(val sqlContext: SQLContext, protected lazy val basePath: StoragePath = metaClient.getBasePath protected lazy val partitionColumns: Array[String] = tableConfig.getPartitionFields.orElse(Array.empty) + //placeholder until pr to persist field types lands + protected lazy val partitionColumnsToRead: Array[String] = if (shouldExtractPartitionValuesFromPartitionPath) Array.empty else tableConfig.getPartitionFields.orElse(Array.empty) + Review Comment: addressed restricting to only custom and timestamp keygen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
