yanghua commented on a change in pull request #1900:
URL: https://github.com/apache/hudi/pull/1900#discussion_r478341019
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/configuration/DeltaConfig.java
##########
@@ -35,7 +35,13 @@
*/
public class DeltaConfig implements Serializable {
+ /**
+ * Output destination type.
Review comment:
IMO, we do not need this comment.
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/generator/GenericRecordFullPayloadGenerator.java
##########
@@ -43,22 +44,39 @@
*/
public class GenericRecordFullPayloadGenerator implements Serializable {
- public static final int DEFAULT_PAYLOAD_SIZE = 1024 * 10; // 10 KB
+ /**
+ * 10 KB.
+ */
+ public static final int DEFAULT_PAYLOAD_SIZE = 1024 * 10;
private static Logger log =
LoggerFactory.getLogger(GenericRecordFullPayloadGenerator.class);
protected final Random random = new Random();
- // The source schema used to generate a payload
+ /**
+ * The source schema used to generate a payload.
Review comment:
Why we should change these comment styles for fields?
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/configuration/DeltaConfig.java
##########
@@ -35,7 +35,13 @@
*/
public class DeltaConfig implements Serializable {
+ /**
+ * Output destination type.
+ */
private final DeltaOutputMode deltaOutputMode;
+ /**
+ * Input data type.
Review comment:
ditto
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/generator/GenericRecordFullPayloadGenerator.java
##########
@@ -43,22 +44,39 @@
*/
public class GenericRecordFullPayloadGenerator implements Serializable {
- public static final int DEFAULT_PAYLOAD_SIZE = 1024 * 10; // 10 KB
+ /**
+ * 10 KB.
Review comment:
we may not change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
