codope commented on code in PR #11601:
URL: https://github.com/apache/hudi/pull/11601#discussion_r1724277531
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -518,6 +518,58 @@ public static boolean validateChecksum(Properties props) {
return Long.parseLong(props.getProperty(TABLE_CHECKSUM.key())) ==
generateChecksum(props);
}
+ /**
+ * This function returns the partition fields joined by
BaseKeyGenerator.FIELD_SEPARATOR. It will also
+ * include the key generator partition type with the field. The key
generator partition type is used for
+ * Custom Key Generator.
+ */
+ public static Option<String>
getPartitionFieldPropForKeyGenerator(HoodieConfig config) {
Review Comment:
For all these static methods, do we have unit test covering different
combinations of `PARTITION_FIELDS` (including complex and simple)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
