majian1998 commented on code in PR #11809:
URL: https://github.com/apache/hudi/pull/11809#discussion_r1726395114
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -109,10 +111,15 @@ object HoodieCLIUtils {
.toMap
}
- def getLockOptions(tablePath: String): Map[String, String] = {
- val props = FileSystemBasedLockProvider.getLockConfig(tablePath)
- props.stringPropertyNames.asScala
- .map(key => key -> props.getString(key))
- .toMap
+ def getLockOptions(tablePath: String, schema: String, lockConfig:
TypedProperties): Map[String, String] = {
+ val customSupportedFSs =
lockConfig.getStringList(HoodieCommonConfig.HOODIE_FS_ATOMIC_CREATION_SUPPORT.key,
",", new ArrayList[String])
+ if (customSupportedFSs.contains(schema) ||
StorageSchemes.isAtomicCreationSupported(schema)) {
Review Comment:
An example: When using Spark to call the clustering procedure, there is a
configuration to add an FS lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
