usberkeley commented on code in PR #11814:
URL: https://github.com/apache/hudi/pull/11814#discussion_r1726801159
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java:
##########
@@ -738,21 +745,18 @@ private List<HoodieInstant> getAllInstants() {
// Following are not valid combinations of actions and state so we
should
// not be generating them.
if (state == State.REQUESTED) {
- if (action.equals(HoodieTimeline.SAVEPOINT_ACTION) ||
action.equals(HoodieTimeline.RESTORE_ACTION)
- || action.equals(HoodieTimeline.ROLLBACK_ACTION)) {
+ if (action.equals(HoodieTimeline.SAVEPOINT_ACTION) ||
action.equals(HoodieTimeline.RESTORE_ACTION)) {
continue;
}
}
- if (state == State.INFLIGHT &&
action.equals(HoodieTimeline.ROLLBACK_ACTION)) {
- continue;
- }
Review Comment:
> So previously the `ROLLBACK` is totally skipped.
Yes, ROLLBACK was totally skipped before. I think it is unreasonable to
ignore ROLLBACK, am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
