codope commented on code in PR #11800:
URL: https://github.com/apache/hudi/pull/11800#discussion_r1728276009
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestMercifulJsonConverter.java:
##########
@@ -140,7 +140,7 @@ void decimalLogicalTypeTest(String avroFilePath, String
groundTruth, String strI
Map<String, Object> data = new HashMap<>();
Schema schema = SchemaTestUtil.getSchemaFromResourceFilePath(avroFilePath);
- GenericRecord record = new GenericData.Record(schema);
+ GenericRecord genericRecord = new GenericData.Record(schema);
Review Comment:
minor: if you're improving naming or style, let's do it in a separate PR
next time. It keeps the core logic changes clean and easy to review.
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieCommonKryoRegistrar.java:
##########
@@ -80,7 +79,6 @@ public void registerClasses(Kryo kryo) {
//kryo.register(BootstrapRecordPayload.class);
AWSDmsAvroPayload.class,
HoodieAvroPayload.class,
- HoodieJsonPayload.class,
Review Comment:
We should not be removing any payload class from Kryo registrar. When
records are shuffled then serialization takes place based on what classes have
been registered here. In case there are records with HoodieJsonPayload that are
shuffled, then it could result in "task not serializable" error. Let's keep the
payload in hudi-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
