yihua commented on code in PR #11634:
URL: https://github.com/apache/hudi/pull/11634#discussion_r1737516761
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1890,7 +1890,7 @@ public static HoodieData<HoodieRecord>
readSecondaryKeysFromBaseFiles(HoodieEngi
List<String> logFilePaths = new ArrayList<>();
baseAndLogFiles.getValue().forEach(logFile -> logFilePaths.add(basePath
+ StoragePath.SEPARATOR + partition + StoragePath.SEPARATOR + logFile));
String filePath = baseAndLogFiles.getKey();
- Option<StoragePath> dataFilePath = filePath.isEmpty() ? Option.empty() :
Option.of(filePath(basePath, partition, filePath));
+ Option<StoragePath> dataFilePath = filePath.isEmpty() ? Option.empty() :
Option.of(FSUtils.constructAbsolutePath(basePath, filePath));
Review Comment:
Is `partition` already included in `filePath`?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -105,7 +138,210 @@ class TestSecondaryIndexPruning extends
SecondaryIndexTestBase {
}
}
- private def checkAnswer(sql: String)(expects: Seq[Any]*): Unit = {
- assertResult(expects.map(row => Row(row:
_*)).toArray.sortBy(_.toString()))(spark.sql(sql).collect().sortBy(_.toString()))
+ @Test
+ def testSecondaryIndexPruningWithUpdates(): Unit = {
+ if (HoodieSparkUtils.gteqSpark3_3) {
+ var hudiOpts = commonOpts
+ hudiOpts = hudiOpts + (
+ DataSourceWriteOptions.TABLE_TYPE.key ->
HoodieTableType.COPY_ON_WRITE.name(),
Review Comment:
Also add a test with a permutation of MOR table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
