yihua commented on code in PR #11882:
URL: https://github.com/apache/hudi/pull/11882#discussion_r1744679645
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -61,9 +61,9 @@
import static
org.apache.hudi.common.config.HoodieMemoryConfig.SPILLABLE_MAP_BASE_PATH;
import static
org.apache.hudi.common.engine.HoodieReaderContext.INTERNAL_META_SCHEMA;
import static
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType.INSTANT_TIME;
-import static
org.apache.hudi.common.table.read.HoodieFileGroupReader.getRecordMergeMode;
+import static
org.apache.hudi.common.table.read.FileSliceReader.getRecordMergeMode;
-public abstract class HoodieBaseFileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
+public abstract class HoodieBaseFileGroupRecordBuffer<T> implements
FileSliceRecordBuffer<T> {
Review Comment:
Can this class be merged with `FileSliceRecordBuffer`?
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/HoodieFileGroupReaderTestUtils.java:
##########
@@ -25,7 +25,7 @@
import org.apache.hudi.common.engine.HoodieReaderContext;
import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.table.read.FileSliceReader;
Review Comment:
We can keep `FileGroupReader` name in this PR. Let @linliu-code decide how
to restructure the classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
