codope commented on code in PR #11891:
URL: https://github.com/apache/hudi/pull/11891#discussion_r1745785792
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/GcsEventsSource.java:
##########
@@ -225,9 +227,8 @@ private void ackOutstandingMessages() {
}
private void logDetails(MetadataMessage message, String msgStr) {
- LOG.info("eventType: " + message.getEventType() + ", objectId: " +
message.getObjectId());
-
if (LOG.isDebugEnabled()) {
+ LOG.debug("eventType: " + message.getEventType() + ", objectId: " +
message.getObjectId());
Review Comment:
same here, please use placeholders
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/GcsEventsSource.java:
##########
@@ -201,13 +202,14 @@ private MessageBatch
processMessages(List<ReceivedMessage> receivedMessages) {
MessageValidity messageValidity = message.shouldBeProcessed();
if (messageValidity.getDecision() == DO_SKIP) {
- LOG.info("Skipping message: " + messageValidity.getDescription());
+ LOG.debug("Skipping message: " + messageValidity.getDescription());
+ skippedMsgCount++;
continue;
}
messages.add(msgStr);
}
-
+ LOG.info("Messages received: " + receivedMessages.size() + ",
toBeProcessed: " + messages.size() + ", skipped: " + skippedMsgCount);
Review Comment:
Please use placeholders (`{}`) instead of concatenating strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
