wangxianghu commented on pull request #2054: URL: https://github.com/apache/hudi/pull/2054#issuecomment-683503914
> Hi @wangxianghu the removal looks good. Good catch! > > While you're here, could you also clean up other unused methods in this class? namely > > ``` > org.apache.hudi.testutils.DataSourceTestUtils#convertToString > org.apache.hudi.testutils.DataSourceTestUtils#convertToStringList > org.apache.hudi.testutils.DataSourceTestUtils#convertKeysToStringList > ``` > > These must have been leftover during a rebase in the past. these methods have been migrated to > > ``` > org.apache.hudi.common.testutils.RawTripTestPayload#recordToString > org.apache.hudi.common.testutils.RawTripTestPayload#recordsToStrings > ``` > > and `convertKeysToStringList` merged to > https://github.com/apache/hudi/blob/b8f4a30efd8bb6257c926a4b79a092cb96b8aff8/hudi-spark/src/test/java/HoodieJavaApp.java#L197 @xushiyan thanks for your review. I have removed the methods you mentioned, PTAL :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
