KnightChess commented on code in PR #11730:
URL: https://github.com/apache/hudi/pull/11730#discussion_r1758562978
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -502,6 +502,8 @@ object HoodieFileIndex extends Logging {
val isMetadataTableEnabled = getConfigValue(options, sqlConf,
HoodieMetadataConfig.ENABLE.key, null)
if (isMetadataTableEnabled != null) {
properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
String.valueOf(isMetadataTableEnabled))
+ } else {
+ properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
String.valueOf(HoodieMetadataConfig.ENABLE.defaultValue()))
Review Comment:
> You should also verify if flipping DEFAULT_METADATA_ENABLE_FOR_READERS
achieves the same.
make sence, but BigQuery use this param too, I only considered spark's
scene in the begin. Can flipping it if there is no problem with other engines
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -502,6 +502,8 @@ object HoodieFileIndex extends Logging {
val isMetadataTableEnabled = getConfigValue(options, sqlConf,
HoodieMetadataConfig.ENABLE.key, null)
if (isMetadataTableEnabled != null) {
properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
String.valueOf(isMetadataTableEnabled))
+ } else {
+ properties.setProperty(HoodieMetadataConfig.ENABLE.key(),
String.valueOf(HoodieMetadataConfig.ENABLE.defaultValue()))
Review Comment:
> You should also verify if flipping DEFAULT_METADATA_ENABLE_FOR_READERS
achieves the same.
make sence, but BigQuery use this param too, I only considered spark's
scene in the begin. Can flipping it if there is no problem with other engines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
