xushiyan commented on code in PR #137: URL: https://github.com/apache/hudi-rs/pull/137#discussion_r1759962241
########## python/tests/conftest.py: ########## @@ -17,12 +17,15 @@ import os import zipfile -from pathlib import Path +from pathlib import Path, PosixPath import pytest +from _pytest.fixtures import SubRequest +from tests.table.table_path import get_table_path -def _extract_testing_table(zip_file_path, target_path) -> str: + +def _extract_testing_table(zip_file_path: Path, target_path: PosixPath) -> str: Review Comment: PosixPath restricted this from running on windows? we'll need to support test and build on windows too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
