xushiyan commented on a change in pull request #2040:
URL: https://github.com/apache/hudi/pull/2040#discussion_r480473768
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##########
@@ -197,12 +204,20 @@ public boolean filesExist(String partition, String
instantTime, String... fileId
public boolean fileExists(String partition, String instantTime, String
fileId) {
try {
return fs.exists(new Path(Paths.get(basePath, partition,
- FSUtils.makeDataFileName(instantTime, "1-0-1", fileId)).toString()));
+ getDataFileNameById(instantTime, fileId)).toString()));
} catch (IOException e) {
throw new HoodieTestTableException(e);
}
}
+ public String getDataFileNameById(String fileId) {
Review comment:
ok makes sense. I've renamed the APIs. I do left
`org.apache.hudi.common.fs.FSUtils#makeDataFileName(java.lang.String,
java.lang.String, java.lang.String)` as is since it is out of test scope.
Renaming it would probably go to another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
