yihua commented on code in PR #7428:
URL: https://github.com/apache/hudi/pull/7428#discussion_r1760518678
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java:
##########
@@ -75,11 +75,17 @@ private HiveSyncContext(Properties props, HiveConf
hiveConf) {
public HiveSyncTool hiveSyncTool() {
HiveSyncMode syncMode =
HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
- return new AwsGlueCatalogSyncTool(props, hiveConf);
+ return loadAwsGlueCatalogSyncTool();
Review Comment:
The code on master has used the reflection already.
```
public HiveSyncTool hiveSyncTool() {
HiveSyncMode syncMode =
HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
return ((HiveSyncTool)
ReflectionUtils.loadClass(AWS_GLUE_CATALOG_SYNC_TOOL_CLASS,
new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class},
props, hiveConf));
}
return new HiveSyncTool(props, hiveConf);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
