vamsikarnika commented on code in PR #11941:
URL: https://github.com/apache/hudi/pull/11941#discussion_r1761650013
##########
hudi-common/src/test/java/org/apache/hudi/avro/TestMercifulJsonConverter.java:
##########
@@ -73,11 +68,7 @@ public void basicConversion() throws IOException {
}
@ParameterizedTest
- @ValueSource(strings = {
- "{\"first\":\"John\",\"last\":\"Smith\"}",
- "[{\"first\":\"John\",\"last\":\"Smith\"}]",
- "{\"first\":\"John\",\"last\":\"Smith\",\"suffix\":3}",
- })
+ @MethodSource("dataNestedJsonAsString")
Review Comment:
Have converted this MethodSource and moved it Test Base class to be reused
by MercifulJsonToRowConverter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
