linliu-code commented on code in PR #11889:
URL: https://github.com/apache/hudi/pull/11889#discussion_r1762097242
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -174,7 +174,16 @@
</exclusion>
</exclusions>
</dependency>
-
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-junit-jupiter</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
`[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile
(default-testCompile) on project hudi-client-common: Compilation failure:
Compilation failure:
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/utils/TestDeletePartitionUtils.java:[33,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[29,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[30,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[37,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[37,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[38,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[38,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[39,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:[39,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieGraphiteMetrics.java:[29,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieGraphiteMetrics.java:[30,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieGraphiteMetrics.java:[35,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieGraphiteMetrics.java:[35,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/prometheus/TestPushGateWayReporter.java:[35,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/prometheus/TestPushGateWayReporter.java:[36,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/prometheus/TestPushGateWayReporter.java:[52,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/prometheus/TestPushGateWayReporter.java:[52,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[33,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[34,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[45,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[45,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[46,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[46,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[47,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/index/TestIndexingCatchupTask.java:[47,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[35,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[36,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[37,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[38,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[46,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[46,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[47,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[47,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[48,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[48,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[49,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[49,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogReporter.java:[58,3]
cannot find symbol
[ERROR] symbol: class ArgumentCaptor
[ERROR] location: class org.apache.hudi.metrics.datadog.TestDatadogReporter
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogMetricsReporter.java:[33,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogMetricsReporter.java:[34,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogMetricsReporter.java:[42,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogMetricsReporter.java:[42,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[29,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[34,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[34,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[35,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[35,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[36,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[36,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[37,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[37,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[38,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/embedded/TestEmbeddedTimelineService.java:[38,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[80,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[80,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[81,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[81,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[82,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/TestCleanPlanner.java:[82,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/cluster/strategy/TestPartitionAwareClusteringPlanStrategy.java:[29,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[27,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[28,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[35,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[35,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[36,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/async/TestAsyncArchiveService.java:[36,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[38,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[39,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[40,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[41,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[52,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[52,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[53,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[53,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[54,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[54,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[55,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[55,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestDatadogHttpClient.java:[64,3]
cannot find symbol
[ERROR] symbol: class ArgumentCaptor
[ERROR] location: class
org.apache.hudi.metrics.datadog.TestDatadogHttpClient
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[34,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[35,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[36,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[51,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[51,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[52,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[52,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[53,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToSevenDowngradeHandler.java:[53,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[36,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[37,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[38,19]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[39,33]
package org.mockito.junit.jupiter does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[49,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[49,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[50,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[50,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[51,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[51,1]
static import only from classes and interfaces
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[52,26]
package org.mockito does not exist
[ERROR]
/Users/linliu/projects/hudi/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/client/http/TestCallbackHttpClient.java:[52,1]
static import only from classes and interfaces
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
