yihua commented on code in PR #11175:
URL: https://github.com/apache/hudi/pull/11175#discussion_r1765850658
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java:
##########
@@ -68,6 +72,7 @@ public class HoodieIncrSource extends RowSource {
public static final Set<String> HOODIE_INCR_SOURCE_READ_OPT_KEYS =
CollectionUtils.createImmutableSet(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key());
private final Option<SnapshotLoadQuerySplitter> snapshotLoadQuerySplitter;
+ private Option<HoodieIngestionMetrics> metricsOption;
Review Comment:
Make this final
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java:
##########
@@ -142,31 +147,30 @@ public static class Config {
public HoodieIncrSource(TypedProperties props, JavaSparkContext
sparkContext, SparkSession sparkSession,
StreamContext streamContext) {
super(props, sparkContext, sparkSession, streamContext);
-
+ this.snapshotLoadQuerySplitter =
SnapshotLoadQuerySplitter.getInstance(props);
+ this.metricsOption = Option.empty();
Review Comment:
Keep the ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
