vinothchandar commented on code in PR #11866:
URL: https://github.com/apache/hudi/pull/11866#discussion_r1765897256
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/UpgradeOrDowngradeCommand.java:
##########
@@ -89,7 +89,7 @@ static String getHoodieTableVersionName(String versionOption,
boolean overrideWi
try {
int versionCode = Integer.parseInt(versionOption);
- return HoodieTableVersion.versionFromCode(versionCode).name();
+ return HoodieTableVersion.fromVersionCode(versionCode).name();
Review Comment:
good point. let me try and clean this up such that, those code paths can
skip validation. lets see if it simplifies things.
if unclear, we can keep that out of scope for this PR (I wanted to break
apart upgrade and downgrade overall) and revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
