danny0405 commented on code in PR #11958:
URL: https://github.com/apache/hudi/pull/11958#discussion_r1766212576
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/BaseHoodieCompactionPlanGenerator.java:
##########
@@ -82,18 +82,20 @@ public HoodieCompactionPlan generateCompactionPlan(String
compactionInstant) thr
// TODO - rollback any compactions in flight
HoodieTableMetaClient metaClient = hoodieTable.getMetaClient();
CompletionTimeQueryView completionTimeQueryView = new
CompletionTimeQueryView(metaClient);
- List<String> partitionPaths = FSUtils.getAllPartitionPaths(
+ List<String> allPartitionPaths = FSUtils.getAllPartitionPaths(
engineContext, metaClient.getStorage(),
writeConfig.getMetadataConfig(), metaClient.getBasePath());
// filter the partition paths if needed to reduce list status
- partitionPaths = filterPartitionPathsByStrategy(writeConfig,
partitionPaths);
- if (partitionPaths.isEmpty()) {
+ List<String> strategyFilterPartitionPaths =
filterPartitionPathsByStrategy(writeConfig, allPartitionPaths);
+ LOG.info("Strategy: {} matched {} partition paths from all {} partitions",
Review Comment:
There is no need to change this class right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
