lokeshj1703 commented on code in PR #11926:
URL: https://github.com/apache/hudi/pull/11926#discussion_r1768463957
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/CustomAvroKeyGenerator.java:
##########
@@ -76,8 +76,11 @@ private static List<BaseKeyGenerator>
getPartitionKeyGenerators(List<String> par
return Collections.emptyList(); // Corresponds to no partition case
} else {
return partitionPathFields.stream().map(field -> {
- Pair<String, CustomAvroKeyGenerator.PartitionKeyType> partitionAndType
= getPartitionFieldAndKeyType(field);
- CustomAvroKeyGenerator.PartitionKeyType keyType =
partitionAndType.getRight();
+ Pair<String, Option<CustomAvroKeyGenerator.PartitionKeyType>>
partitionAndType = getPartitionFieldAndKeyType(field);
+ if (partitionAndType.getRight().isEmpty()) {
+ throw new HoodieKeyException("Unable to find field names for
partition path in proper format");
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]