leesf commented on a change in pull request #2059:
URL: https://github.com/apache/hudi/pull/2059#discussion_r482044269
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/TypedProperties.java
##########
@@ -37,10 +38,12 @@ public TypedProperties(Properties defaults) {
super(defaults);
}
- private void checkKey(String property) {
- if (!containsKey(property)) {
+ private boolean checkKey(String property) {
Review comment:
> I think the checkkey is better。That was its original name。containsKey
in parent class，
`checkKey` should not return boolean and should throw exception from
semantically. ` containsKey` or `keyExists` should return boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
