yihua commented on code in PR #11951:
URL: https://github.com/apache/hudi/pull/11951#discussion_r1772378834
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/IndexCommands.scala:
##########
@@ -76,7 +76,14 @@ case class DropIndexCommand(table: CatalogTable,
override def run(sparkSession: SparkSession): Seq[Row] = {
val tableId = table.identifier
val metaClient = createHoodieTableMetaClient(tableId, sparkSession)
- SecondaryIndexManager.getInstance().drop(metaClient, indexName,
ignoreIfNotExists)
+ try {
+ // need to ensure that the index name is for a valid partition type
+ MetadataPartitionType.fromPartitionPath(indexName)
+ HoodieSparkIndexClient.getInstance(sparkSession).drop(metaClient,
indexName, ignoreIfNotExists)
+ } catch {
+ case _: IllegalArgumentException =>
+ SecondaryIndexManager.getInstance().drop(metaClient, indexName,
ignoreIfNotExists)
Review Comment:
Got it. Let's have JIRA to track that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
