codope commented on code in PR #12001:
URL: https://github.com/apache/hudi/pull/12001#discussion_r1776667897
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1847,9 +1847,15 @@ public static HoodieData<HoodieRecord>
readRecordKeysFromFileSlices(HoodieEngine
}
public static Schema
getProjectedSchemaForFunctionalIndex(HoodieIndexDefinition indexDefinition,
HoodieTableMetaClient metaClient) throws Exception {
- TableSchemaResolver schemaResolver = new TableSchemaResolver(metaClient);
- Schema tableSchema = schemaResolver.getTableAvroSchema();
- return addMetadataFields(getSchemaForFields(tableSchema,
indexDefinition.getSourceFields()));
+ Schema tableSchema = new
TableSchemaResolver(metaClient).getTableAvroSchema();
+ List<String> partitionFields =
metaClient.getTableConfig().getPartitionFields()
+ .map(Arrays::asList)
+ .orElse(Collections.emptyList());
+ List<String> sourceFields = indexDefinition.getSourceFields();
+ List<String> mergedFields = new ArrayList<>(partitionFields.size() +
sourceFields.size());
+ mergedFields.addAll(partitionFields);
+ mergedFields.addAll(sourceFields);
Review Comment:
this is a bug fix which appeared after building functional index for
non-parititon column. While loading file slices, the relation expects partition
field as well. So, we are projecting metadata fields + partition fields +
fields on which func index is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
