jonvex commented on code in PR #12006:
URL: https://github.com/apache/hudi/pull/12006#discussion_r1778742266


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HiveHoodieReaderContext.java:
##########
@@ -232,6 +232,12 @@ public UnaryOperator<ArrayWritable> projectRecord(Schema 
from, Schema to, Map<St
     return HoodieArrayWritableAvroUtils.projectRecord(from, to);
   }
 
+  @Override
+  public Comparable castValue(Comparable value, Schema.Type newType) {
+    //TODO: [HUDI-8261] actually do casting here

Review Comment:
   I just didn't think it was p0. We don't have schema evolution support for 
hive anyways, so I made a ticket to fix those both in the future. It might not 
take that long to implement, but the testing infra I would need to create to 
validate it _**properly**_ might take a couple days.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to