usberkeley commented on code in PR #12065:
URL: https://github.com/apache/hudi/pull/12065#discussion_r1791760808
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -255,11 +255,12 @@ public static HoodieTableMetaClient initTableIfNotExists(
.setTableName(conf.getString(FlinkOptions.TABLE_NAME))
.setTableVersion(conf.getInteger(FlinkOptions.WRITE_TABLE_VERSION))
.setDatabaseName(conf.getString(FlinkOptions.DATABASE_NAME))
- .setRecordKeyFields(conf.getString(FlinkOptions.RECORD_KEY_FIELD,
null))
+ .setRecordKeyFields(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review Comment:
> Why change the default value, may not work for pk-less table scenario.
Because when querying with the Log Scanner, it is necessary to merge records
based on the record key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
