yihua commented on code in PR #12073:
URL: https://github.com/apache/hudi/pull/12073#discussion_r1796175566
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestPartitionStatsIndex.scala:
##########
@@ -178,7 +177,7 @@ class TestPartitionStatsIndex extends
PartitionStatsIndexTestBase {
override def apply(): Boolean = {
try {
doWriteAndValidateDataAndPartitionStats(hudiOpts,
- operation = DataSourceWriteOptions.UPSERT_OPERATION_OPT_VAL,
+ operation = DataSourceWriteOptions.BULK_INSERT_OPERATION_OPT_VAL,
Review Comment:
Could we add validation on the preconditions of the end state before
validation, i.e., in this case there must be two commits with overlapping
commit time span (based on the instant time and completion time)?
I think it might also be valuable to add the case where there are concurrent
writers but the second writer has a conflict (add the validation on this
precondition); and the partition stats index should not be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
