xushiyan commented on code in PR #163:
URL: https://github.com/apache/hudi-rs/pull/163#discussion_r1797630157
##########
python/tests/test_table_read.py:
##########
@@ -133,7 +133,9 @@ def test_sample_table(get_sample_table):
},
]
- table = HudiTable(table_path, {"hoodie.read.as.of.timestamp":
"20240402123035233"})
+ table = HudiTable(
+ table_path, hudi_options={"hoodie.read.as.of.timestamp":
"20240402123035233"}
+ )
Review Comment:
ditto
##########
python/src/internal.rs:
##########
@@ -101,12 +102,18 @@ pub struct HudiTable {
#[pymethods]
impl HudiTable {
#[new]
- #[pyo3(signature = (table_uri, options = None))]
- fn new(table_uri: &str, options: Option<HashMap<String, String>>) ->
PyResult<Self> {
- let _table = rt().block_on(Table::new_with_options(
- table_uri,
- options.unwrap_or_default(),
- ))?;
+ #[pyo3(signature = (table_uri, hudi_options = None, storage_options =
None))]
+ fn new(
+ table_uri: &str,
+ hudi_options: Option<HashMap<String, String>>,
+ storage_options: Option<HashMap<String, String>>,
Review Comment:
this can be reverted as well
##########
python/hudi/_internal.pyi:
##########
@@ -38,7 +38,8 @@ class HudiTable:
def __init__(
self,
table_uri: str,
- options: Optional[Dict[str, str]] = None,
+ hudi_options: Optional[Dict[str, str]] = None,
+ storage_options: Optional[Dict[str, str]] = None,
Review Comment:
you can revert this change - we keep python and rust api as close as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
