garyli1019 commented on a change in pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#discussion_r484659992
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -49,6 +49,7 @@ object DataSourceReadOptions {
val QUERY_TYPE_SNAPSHOT_OPT_VAL = "snapshot"
val QUERY_TYPE_READ_OPTIMIZED_OPT_VAL = "read_optimized"
val QUERY_TYPE_INCREMENTAL_OPT_VAL = "incremental"
+ val QUERY_TYPE_MOR_INCREMENTAL_OPT_VAL = "mor_incremental"
Review comment:
This option was supposed to distinguish when the user wants to run an
incremental query on the MOR table but on the parquet files only. This was not
really necessary because users can just define the timestamp range to achieve
the same goal. So we can just use the tableType. If COW, use the old way, if
MOR, use the new relation. Don't need an extra option anymore imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
