xushiyan commented on code in PR #170:
URL: https://github.com/apache/hudi-rs/pull/170#discussion_r1799844824
##########
crates/core/src/table/partition.rs:
##########
@@ -265,13 +265,36 @@ impl PartitionFilter {
safe: false,
format_options: Default::default(),
};
+
+ let value = match data_type {
+ DataType::Date32 => Self::trim_single_quotes(value),
+ DataType::Date64 => Self::trim_single_quotes(value),
+ DataType::Utf8 => Self::trim_single_quotes(value),
+ DataType::LargeUtf8 => Self::trim_single_quotes(value),
+ DataType::Utf8View => Self::trim_single_quotes(value),
Review Comment:
yes it should also applies to any temporal type that is supposed to be
parsed from string in sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]