codope commented on code in PR #12096:
URL: https://github.com/apache/hudi/pull/12096#discussion_r1800504308
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestFunctionalIndex.scala:
##########
@@ -557,12 +553,86 @@ class TestFunctionalIndex extends HoodieSparkSqlTestBase {
checkAnswer(metadataSql)(
Seq("2020-09-26", "2021-09-26"),
Seq("2022-09-26", "2022-09-26"),
+ Seq("2022-09-26", "2022-09-26"), // for file in name=a2
Seq("2024-09-26", "2024-09-26") // for file in name=a3
)
}
}
}
+ // Test functional index using column stats and bloom filters, and then
clean older version, and check index is correct.
+ test("Test Functional Index With Cleaning") {
Review Comment:
done.. Now we have test with cleaning for table types and isPartitioned
combination. By `a test for MOR table where entire file slice is cleaned up`, I
am assuming you mean all but the latest file slice in a partition is cleaned
up. So, the test is now compacting the table in case of mor so that prev file
slice is cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
