pratyakshsharma commented on a change in pull request #1984:
URL: https://github.com/apache/hudi/pull/1984#discussion_r485182381
##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java
##########
@@ -41,7 +41,7 @@
private static final String STRUCT_NAME = "hoodieRowTopLevelField";
private static final String NAMESPACE = "hoodieRow";
- protected transient TypedProperties config;
+ protected TypedProperties config;
Review comment:
If we do not want to make config object as transient, we have 2 choices
-
1. introduce a new TypedProperties instance in CustomKeyGenerator
2. introduce a new TimestampBasedKeyGenerator instance in
CustomKeyGenerator, which gets initialised only if needed.
Please suggest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
