codope commented on code in PR #12098:
URL: https://github.com/apache/hudi/pull/12098#discussion_r1801035503
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -61,11 +70,15 @@ public BaseActionExecutor(HoodieEngineContext context,
HoodieWriteConfig config,
*
* @param metadata commit metadata of interest.
*/
- protected final void writeTableMetadata(HoodieCommitMetadata metadata,
HoodieData<WriteStatus> writeStatus, String actionType) {
+ protected final void writeTableMetadata(HoodieCommitMetadata metadata,
HoodieData<WriteStatus> writeStatus, String operationType) {
Option<HoodieTableMetadataWriter> metadataWriterOpt =
table.getMetadataWriter(instantTime);
if (metadataWriterOpt.isPresent()) {
try (HoodieTableMetadataWriter metadataWriter = metadataWriterOpt.get())
{
- metadataWriter.updateFromWriteStatuses(metadata, writeStatus,
instantTime);
+ if (operationType.equals("restore")) {
Review Comment:
no need to check here.. util method in `MetadataPartitionType` suffices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
