[ 
https://issues.apache.org/jira/browse/HUDI-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Y Ethan Guo updated HUDI-8373:
------------------------------
    Description: 
It can be confusing to use "Start" or "Time" without much context as we have 
the checkpoint to resume from and stop at for the incremental queries, and 
instant and completion time in the timeline.  So it would be good to do the 
following renaming and make the names consistent across the code base:
 * "beginCompletionTime": checkpoint to resume from
 * "endCompletionTime": checkpoint to stop at
 * "instantTime"/"commitTime": for instant time or start time of an instant on 
the timeline
 * "completionTime": completion time of an instant

Do not use "startTime", "endTime", etc that can cause confusion.

 

> Improve variable naming around time in incremental query logic
> --------------------------------------------------------------
>
>                 Key: HUDI-8373
>                 URL: https://issues.apache.org/jira/browse/HUDI-8373
>             Project: Apache Hudi
>          Issue Type: Improvement
>            Reporter: Y Ethan Guo
>            Priority: Major
>             Fix For: 1.1.0
>
>
> It can be confusing to use "Start" or "Time" without much context as we have 
> the checkpoint to resume from and stop at for the incremental queries, and 
> instant and completion time in the timeline.  So it would be good to do the 
> following renaming and make the names consistent across the code base:
>  * "beginCompletionTime": checkpoint to resume from
>  * "endCompletionTime": checkpoint to stop at
>  * "instantTime"/"commitTime": for instant time or start time of an instant 
> on the timeline
>  * "completionTime": completion time of an instant
> Do not use "startTime", "endTime", etc that can cause confusion.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to