[PR] [HUDI-8383] Cached `OptionsResolver::isInsertOverwrite` in `BucketStreamWriteFunction::processElement` [hudi]

Wed, 16 Oct 2024 05:00:27 -0700 


geserdugarov opened a new pull request, #12113:
URL: https://github.com/apache/hudi/pull/12113

   ### Change Logs
   
   `OptionsResolver::isInsertOverwrite` is used in 
`BucketStreamWriteFunction::processElement`, which means that it's called for 
each record. And `OptionsResolver::isInsertOverwrite` uses strings comparison, 
which leads to excessive memory allocation.
   
   Before changes:
   ![02 - string comparison memory 
alloc](https://github.com/user-attachments/assets/a73ec405-7a28-45c1-b4f5-fe173ab35827)
   ![03 - string comparison memory 
alloc](https://github.com/user-attachments/assets/b86f6c56-05a5-4764-b661-f1334dd157b0)
   
   After changes:
   ![04 - string comparison memory alloc with 
cache](https://github.com/user-attachments/assets/c13b4e39-d1df-4d8a-9b73-5db70af77684)
   
   ### Impact
   
   Memory utilization optimization
   
   ### Risk level (write none, low medium or high below)
   
   No
   
   ### Documentation Update
   
   No need
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to