codope commented on code in PR #12081:
URL: https://github.com/apache/hudi/pull/12081#discussion_r1802476881
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -447,7 +447,7 @@ private static Comparable<?>
convertToNativeJavaType(PrimitiveType primitiveType
synchronized (primitiveType.stringifier()) {
// Date logical type is implemented as a signed INT32
// REF:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md
- return java.sql.Date.valueOf(
+ return java.time.LocalDate.parse(
Review Comment:
`LocalDate` should be parseable with `java.sql.Date.valueOf()`, so why do we
need this change?
https://docs.oracle.com/javase/8/docs/api/java/sql/Date.html#valueOf-java.time.LocalDate-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
