yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1804233787
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -108,7 +108,7 @@ object DataSourceReadOptions {
.key("hoodie.datasource.read.begin.instanttime")
.noDefaultValue()
.withDocumentation("Required when `" + QUERY_TYPE.key() + "` is set to `"
+ QUERY_TYPE_INCREMENTAL_OPT_VAL + "`. Represents the instant time to start
incrementally pulling data from. The instanttime here need not necessarily "
- + "correspond to an instant on the timeline. New data written with an
instant_time > BEGIN_INSTANTTIME are fetched out. "
+ + "correspond to an instant on the timeline. New data written with an
instant_time >= BEGIN_INSTANTTIME are fetched out. "
Review Comment:
Fixed. I also renamed the variable and revised the docs as a whole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
