codope commented on code in PR #12119:
URL: https://github.com/apache/hudi/pull/12119#discussion_r1805009723
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieMetadataTableValidator.java:
##########
@@ -270,10 +282,10 @@ public void testGetFSSecondaryKeyToRecordKeys() throws
IOException {
for (String secKey : new String[]{"abc", "cde", "def"}) {
// There is one to one mapping between record key and secondary key
String recKey = "row" + i++;
- List<String> recKeys = validator.getFSSecondaryKeyToRecordKeys(new
HoodieSparkEngineContext(jsc, sqlContext), basePath,
+ Set<String> recKeys = validator.getFSSecondaryKeyToRecordKeys(new
HoodieSparkEngineContext(jsc, sqlContext), basePath,
metaClient.getActiveTimeline().lastInstant().get().getTimestamp(),
"not_record_key_col", Collections.singletonList(secKey))
.get(secKey);
- assertEquals(Collections.singletonList(recKey), recKeys);
+ assertEquals(Collections.singleton(recKey), recKeys);
Review Comment:
Is this intended change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
