codope commented on code in PR #12121:
URL: https://github.com/apache/hudi/pull/12121#discussion_r1805122912
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2201,7 +2201,7 @@ public static HoodieData<HoodieRecord>
convertMetadataToPartitionStatsRecords(Ho
int parallelism = Math.max(Math.min(partitionedWriteStats.size(),
metadataConfig.getPartitionStatsIndexParallelism()), 1);
boolean shouldScanColStatsForTightBound =
MetadataPartitionType.COLUMN_STATS.isMetadataPartitionAvailable(dataMetaClient)
- && metadataConfig.isPartitionStatsIndexTightBoundEnabled() &&
WriteOperationType.isPartitionStatsTightBoundRequired(commitMetadata.getOperationType());
+ &&
(metadataConfig.isPartitionStatsIndexTightBoundEnabledOnEveryCommit() ||
WriteOperationType.isPartitionStatsTightBoundRequired(commitMetadata.getOperationType()));
Review Comment:
This condition looks good to me. But, I am wondering if colstats is not
enabled, but tight bound is enabled, should we just bail out even earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
